Fix GDI handle leak when clearing MenuItem images #2530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When setting a null image on a MenuItem, the existing bitmap handle was overwritten with 0 without being released, causing a GDI handle leak if the MenuItem previously had an icon. This commit makes sure the handle is always deleted if it was set before.
Contributor
Test Results 118 files ±0 118 suites ±0 9m 57s ⏱️ -26s For more details on these failures, see this check. Results for commit f9efe01. ± Comparison against base commit a479377. |
Contributor
Author
|
Failed tests have been raised as an issue already #2516 |
fedejeanne
approved these changes
Sep 22, 2025
HeikoKlare
approved these changes
Sep 22, 2025
Contributor
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
Fix totally makes sense and works as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting a null image on a MenuItem, the existing bitmap handle was overwritten with 0 without being released, causing a GDI handle leak if the MenuItem previously had an icon. This commit makes sure the handle is always deleted if it was set before.
Steps to reproduce
1)Open a Runtime workspace
2)Double click(or open) a file in the Package explorer
3)Compare the GDI handles in the task manager before and after; it increases by 3 without this fix
This regression was introduced in #1914. The fix ensures that old handles are properly deleted before being replaced.